gh-155860: Reject a detached window in panel.replace() - #155861
Merged
serhiy-storchaka merged 1 commit intoAug 16, 2026
Conversation
curses.screen.close() detaches the screen's standard window: the wrapper object stays alive but the curses window behind it is gone. panel.replace() did not check for that, so it stored the detached window in the panel and curses dereferenced it on the panel's next use, killing the interpreter with SIGSEGV. Raise curses.panel.error instead, the way new_panel() already does on the same window.
Documentation build overview
|
serhiy-storchaka
self-requested a review
August 15, 2026 20:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reject a window detached by
curses.screen.close()inpanel.replace(), raisingcurses.panel.errorthe waynew_panel()already does, and add a regression test.new_panel()needs no change: it already rejects that window.No NEWS entry:
screen.close()is new in 3.16 and unreleased, so no released version can reach the crash.panel.replace()is given a detached window #155860